Skip to content

docs: empty alias with importas #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2024
Merged

docs: empty alias with importas #5226

merged 2 commits into from
Dec 14, 2024

Conversation

ccoVeille
Copy link
Contributor

I discovered the feature of enforcing empty aliases with

A fix was provided

I think it could be interesting to document it.

@ldez ldez changed the title importas: document the feature of using empty alias docs: empty alias with importas Dec 13, 2024
@ldez ldez self-requested a review December 13, 2024 21:32
@ldez
Copy link
Member

ldez commented Dec 13, 2024 •
edited
Loading

The reference file should be (when possible) exhaustive about options but not about usage.
This is not exactly a source of examples or "how to".
We should limit them or the linter section will quickly become unreadable (or more unreadable).

So I reduced the example to only one explicit empty alias.

@ldez ldez added the enhancement New feature or improvement label Dec 13, 2024
@ldez ldez added this to the next milestone Dec 13, 2024
@ccoVeille
Copy link
Contributor Author

Sure, no problems

ldez
ldez approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 7ac2044 into golangci:master Dec 14, 2024
15 checks passed
@ccoVeille ccoVeille deleted the importas-doc branch December 14, 2024 06:46
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoVeille @ldez